staging: vchiq_shim: delete vchi_service_create
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tue, 20 Nov 2018 14:53:38 +0000 (15:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 09:10:09 +0000 (10:10 +0100)
No one is using the API neither in the actual staging tree nor in the
downstream tree (https://github.com/raspberrypi/linux).

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchi/vchi.h
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c

index 01381904775d770442f7ec4c253dde36771154ec..379a16ebfd5b61d507604d2b1768f1252322580a 100644 (file)
@@ -113,11 +113,6 @@ extern uint32_t vchi_current_time(VCHI_INSTANCE_T instance_handle);
 /******************************************************************************
  Global service API
  *****************************************************************************/
-// Routine to create a named service
-extern int32_t vchi_service_create(VCHI_INSTANCE_T instance_handle,
-                                  SERVICE_CREATION_T *setup,
-                                  VCHI_SERVICE_HANDLE_T *handle);
-
 // Routine to destroy a service
 extern int32_t vchi_service_destroy(const VCHI_SERVICE_HANDLE_T handle);
 
index c3223fcdaf872c7bec7cf2b2385e390638cc8c18..81cac68f4b78fcde845e6a079eaa84d7dcfe7f75 100644 (file)
@@ -660,38 +660,6 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
 }
 EXPORT_SYMBOL(vchi_service_open);
 
-int32_t vchi_service_create(VCHI_INSTANCE_T instance_handle,
-       SERVICE_CREATION_T *setup,
-       VCHI_SERVICE_HANDLE_T *handle)
-{
-       VCHIQ_INSTANCE_T instance = (VCHIQ_INSTANCE_T)instance_handle;
-       struct shim_service *service = service_alloc(instance, setup);
-
-       *handle = (VCHI_SERVICE_HANDLE_T)service;
-
-       if (service) {
-               VCHIQ_SERVICE_PARAMS_T params;
-               VCHIQ_STATUS_T status;
-
-               memset(&params, 0, sizeof(params));
-               params.fourcc = setup->service_id;
-               params.callback = shim_callback;
-               params.userdata = service;
-               params.version = setup->version.version;
-               params.version_min = setup->version.version_min;
-               status = vchiq_add_service(instance, &params, &service->handle);
-
-               if (status != VCHIQ_SUCCESS) {
-                       service_free(service);
-                       service = NULL;
-                       *handle = NULL;
-               }
-       }
-
-       return (service != NULL) ? 0 : -1;
-}
-EXPORT_SYMBOL(vchi_service_create);
-
 int32_t vchi_service_close(const VCHI_SERVICE_HANDLE_T handle)
 {
        int32_t ret = -1;