bcachefs: Fix error path of bch2_link_trans()
authorYouling Tang <tangyouling@kylinos.cn>
Tue, 30 Apr 2024 03:28:39 +0000 (11:28 +0800)
committerKent Overstreet <kent.overstreet@linux.dev>
Wed, 8 May 2024 21:29:21 +0000 (17:29 -0400)
In bch2_link_trans(), if bch2_inode_nlink_inc() fails, it needs to
call bch2_trans_iter_exit() in the error path.

Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/fs-common.c

index 6c737def357e3c77c129f21567cefa51c49cfb75..508d029ac53d067226162bd69ba66f48faabcfa8 100644 (file)
@@ -200,12 +200,12 @@ int bch2_link_trans(struct btree_trans *trans,
 
        ret = bch2_inode_peek(trans, &inode_iter, inode_u, inum, BTREE_ITER_intent);
        if (ret)
-               goto err;
+               return ret;
 
        inode_u->bi_ctime = now;
        ret = bch2_inode_nlink_inc(inode_u);
        if (ret)
-               return ret;
+               goto err;
 
        ret = bch2_inode_peek(trans, &dir_iter, dir_u, dir, BTREE_ITER_intent);
        if (ret)