spi: dw: Drop default number of CS setting
authorSerge Semin <fancer.lancer@gmail.com>
Wed, 24 Apr 2024 15:06:45 +0000 (18:06 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 3 May 2024 02:09:25 +0000 (11:09 +0900)
DW APB/AHB SSI core now supports the procedure automatically detecting the
number of native chip-select lines. Thus there is no longer point in
defaulting to four CS if the platform doesn't specify the real number
especially seeing the default number didn't correspond to any original DW
APB/AHB databook.

Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20240424150657.9678-5-fancer.lancer@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-mmio.c

index cc74cbe03431d8a9e62275927620c3f5addacd57..c56de35eca988ee46e9a10de650fc2159cc603cc 100644 (file)
@@ -320,7 +320,6 @@ static int dw_spi_mmio_probe(struct platform_device *pdev)
        struct resource *mem;
        struct dw_spi *dws;
        int ret;
-       int num_cs;
 
        dwsmmio = devm_kzalloc(&pdev->dev, sizeof(struct dw_spi_mmio),
                        GFP_KERNEL);
@@ -364,11 +363,8 @@ static int dw_spi_mmio_probe(struct platform_device *pdev)
                                     &dws->reg_io_width))
                dws->reg_io_width = 4;
 
-       num_cs = 4;
-
-       device_property_read_u32(&pdev->dev, "num-cs", &num_cs);
-
-       dws->num_cs = num_cs;
+       /* Rely on the auto-detection if no property specified */
+       device_property_read_u32(&pdev->dev, "num-cs", &dws->num_cs);
 
        init_func = device_get_match_data(&pdev->dev);
        if (init_func) {