powerpc: Make cpu_spec __ro_after_init
authorMichael Ellerman <mpe@ellerman.id.au>
Wed, 25 Oct 2023 01:24:52 +0000 (12:24 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 27 Nov 2023 11:01:14 +0000 (22:01 +1100)
The cpu_spec is a struct holding various information about the CPU the
kernel is executing on. It's populated early in boot and must not change
after that.

In particular the cpu_features and mmu_features hold the set of
discovered CPU/MMU features and are used to set static keys for each
feature, and do binary patching of assembly. So any change to the
cpu_features/mmu_features later in boot will not be reflected in
the state of the static keys or patched code.

There is already logic to check that cpu_features/mmu_features don't
change, see check_features() in feature-fixups.c.

But as another layer of protection the entire cpu_spec should be read
only after init, annotate it as such.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231025012452.1985680-1-mpe@ellerman.id.au
arch/powerpc/kernel/cputable.c

index e97a0fd0ae905d7e5005fc75b78423256b6aa432..6f6801da9dc1e26336e2bd8d59ab0f5085e349c5 100644 (file)
@@ -20,9 +20,9 @@
 #include <asm/setup.h>
 #include <asm/cpu_setup.h>
 
-static struct cpu_spec the_cpu_spec __read_mostly;
+static struct cpu_spec the_cpu_spec __ro_after_init;
 
-struct cpu_spec* cur_cpu_spec __read_mostly = NULL;
+struct cpu_spec *cur_cpu_spec __ro_after_init = NULL;
 EXPORT_SYMBOL(cur_cpu_spec);
 
 /* The platform string corresponding to the real PVR */