drm/nouveau: Fix reference count leak in nouveau_connector_detect

nouveau_connector_detect() calls pm_runtime_get_sync and in turn
increments the reference count. In case of failure, decrement the
ref count before returning the error.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index ab2c2b2cab10f55c8706da4ae49441b431374528..1fa5d5614261719df12d1674f3a2b8dc6271b3d7 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -571,8 +571,10 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
                pm_runtime_get_noresume(dev->dev);
        } else {
                ret = pm_runtime_get_sync(dev->dev);
-               if (ret < 0 && ret != -EACCES)
+               if (ret < 0 && ret != -EACCES) {
+                       pm_runtime_put_autosuspend(dev->dev);
                        return conn_status;
+               }
        }
 
        nv_encoder = nouveau_connector_ddc_detect(connector);