drm/xe/display: fix error handling flow when device probing fails
authorKoby Elbaz <kelbaz@habana.ai>
Wed, 30 Aug 2023 06:33:32 +0000 (09:33 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:44:30 +0000 (11:44 -0500)
Upon device probe failure, rolling back the initialization
should be done in reversed order.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_device.c

index 98d7e7fa12d849c3b587082e17fb7a1bacf27b66..1202f8007f795cad222d09521358f389266fefa3 100644 (file)
@@ -427,11 +427,11 @@ int xe_device_probe(struct xe_device *xe)
 
        err = xe_display_init(xe);
        if (err)
-               goto err_fini_display;
+               goto err_irq_shutdown;
 
        err = drm_dev_register(&xe->drm, 0);
        if (err)
-               goto err_irq_shutdown;
+               goto err_fini_display;
 
        xe_display_register(xe);