drm/i915: Dump blanking start/end
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 13 Feb 2023 22:52:51 +0000 (00:52 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 17 Feb 2023 21:26:09 +0000 (23:26 +0200)
With the delayed vblank we need to start knowing where
the blanking periods start. So let's start dumping
out also the blanking start/end timings.

And while at it let's try to make that huge list of
numbers somewhat legible by indicating what each value
means. Also drop the 'type' since that doesn't really
mean anything for the crtc_ timings.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230213225258.2127-6-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c

index 2422d6ef57776487e6fc34d535f8493d919007e8..766633566fd6d1cbfcd8d6583d6c84e0f91ccddc 100644 (file)
 static void intel_dump_crtc_timings(struct drm_i915_private *i915,
                                    const struct drm_display_mode *mode)
 {
-       drm_dbg_kms(&i915->drm, "crtc timings: %d %d %d %d %d %d %d %d %d, "
-                   "type: 0x%x flags: 0x%x\n",
+       drm_dbg_kms(&i915->drm, "crtc timings: clock=%d, "
+                   "hd=%d hb=%d-%d hs=%d-%d ht=%d, "
+                   "vd=%d vb=%d-%d vs=%d-%d vt=%d, "
+                   "flags=0x%x\n",
                    mode->crtc_clock,
-                   mode->crtc_hdisplay, mode->crtc_hsync_start,
-                   mode->crtc_hsync_end, mode->crtc_htotal,
-                   mode->crtc_vdisplay, mode->crtc_vsync_start,
-                   mode->crtc_vsync_end, mode->crtc_vtotal,
-                   mode->type, mode->flags);
+                   mode->crtc_hdisplay, mode->crtc_hblank_start, mode->crtc_hblank_end,
+                   mode->crtc_hsync_start, mode->crtc_hsync_end, mode->crtc_htotal,
+                   mode->crtc_vdisplay, mode->crtc_vblank_start, mode->crtc_vblank_end,
+                   mode->crtc_vsync_start, mode->crtc_vsync_end, mode->crtc_vtotal,
+                   mode->flags);
 }
 
 static void