tests: improve test descriptions
authorBartosz Golaszewski <bartekgola@gmail.com>
Thu, 2 Mar 2017 10:20:36 +0000 (11:20 +0100)
committerBartosz Golaszewski <bartekgola@gmail.com>
Thu, 2 Mar 2017 10:20:36 +0000 (11:20 +0100)
Use the test descriptions to tell the user exactly what
each test is validating.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
tests/unit/tests-chip.c
tests/unit/tests-iter.c
tests/unit/tests-line.c
tests/unit/tests-simple-api.c

index 5d6ae91c731cec758ec6afaf9c0cdbf0d0e87410..d94eaa853d339a5aeddfd4d4177d35ca2e0df729 100644 (file)
@@ -21,7 +21,7 @@ static void chip_open_good(void)
        GU_ASSERT_NOT_NULL(chip);
 }
 GU_DEFINE_TEST(chip_open_good,
-              "gpiod_chip_open() good",
+              "gpiod_chip_open() good",
               GU_LINES_UNNAMED, { 8 });
 
 static void chip_open_nonexistent(void)
@@ -33,7 +33,7 @@ static void chip_open_nonexistent(void)
        GU_ASSERT_EQ(gpiod_errno(), ENOENT);
 }
 GU_DEFINE_TEST(chip_open_nonexistent,
-              "gpiod_chip_open() nonexistent",
+              "gpiod_chip_open() - nonexistent chip",
               GU_LINES_UNNAMED, { 8 });
 
 static void chip_open_notty(void)
@@ -45,7 +45,7 @@ static void chip_open_notty(void)
        GU_ASSERT_EQ(gpiod_errno(), ENOTTY);
 }
 GU_DEFINE_TEST(chip_open_notty,
-              "gpiod_chip_open() notty",
+              "gpiod_chip_open() notty",
               GU_LINES_UNNAMED, { 8 });
 
 static void chip_open_by_name_good(void)
@@ -56,7 +56,7 @@ static void chip_open_by_name_good(void)
        GU_ASSERT_NOT_NULL(chip);
 }
 GU_DEFINE_TEST(chip_open_by_name_good,
-              "gpiod_chip_open_by_name() good",
+              "gpiod_chip_open_by_name() good",
               GU_LINES_UNNAMED, { 8 });
 
 static void chip_open_by_number_good(void)
@@ -67,7 +67,7 @@ static void chip_open_by_number_good(void)
        GU_ASSERT_NOT_NULL(chip);
 }
 GU_DEFINE_TEST(chip_open_by_number_good,
-              "gpiod_chip_open_by_number() good",
+              "gpiod_chip_open_by_number() good",
               GU_LINES_UNNAMED, { 8 });
 
 static void chip_open_lookup(void)
@@ -96,7 +96,7 @@ static void chip_open_lookup(void)
        GU_ASSERT_STR_EQ(gpiod_chip_name(chip_by_label), gu_chip_name(1));
 }
 GU_DEFINE_TEST(chip_open_lookup,
-              "gpiod_chip_open_lookup()",
+              "gpiod_chip_open_lookup() - good",
               GU_LINES_UNNAMED, { 8, 8, 8 });
 
 static void chip_open_by_label_good(void)
@@ -108,7 +108,7 @@ static void chip_open_by_label_good(void)
        GU_ASSERT_STR_EQ(gpiod_chip_name(chip), gu_chip_name(3));
 }
 GU_DEFINE_TEST(chip_open_by_label_good,
-              "chip_open_by_label() good",
+              "gpiod_chip_open_by_label() - good",
               GU_LINES_UNNAMED, { 4, 4, 4, 4, 4 });
 
 static void chip_open_by_label_bad(void)
@@ -119,7 +119,7 @@ static void chip_open_by_label_bad(void)
        GU_ASSERT_NULL(chip);
 }
 GU_DEFINE_TEST(chip_open_by_label_bad,
-              "chip_open_by_label() bad",
+              "gpiod_chip_open_by_label() - bad",
               GU_LINES_UNNAMED, { 4, 4, 4, 4, 4 });
 
 static void chip_name(void)
@@ -139,7 +139,9 @@ static void chip_name(void)
        GU_ASSERT_STR_EQ(gpiod_chip_name(chip1), gu_chip_name(1));
        GU_ASSERT_STR_EQ(gpiod_chip_name(chip2), gu_chip_name(2));
 }
-GU_DEFINE_TEST(chip_name, "gpiod_chip_name()", GU_LINES_UNNAMED, { 8, 8, 8 });
+GU_DEFINE_TEST(chip_name,
+              "gpiod_chip_name()",
+              GU_LINES_UNNAMED, { 8, 8, 8 });
 
 static void chip_label(void)
 {
@@ -158,7 +160,8 @@ static void chip_label(void)
        GU_ASSERT_STR_EQ(gpiod_chip_label(chip1), "gpio-mockup-B");
        GU_ASSERT_STR_EQ(gpiod_chip_label(chip2), "gpio-mockup-C");
 }
-GU_DEFINE_TEST(chip_label, "gpiod_chip_label()",
+GU_DEFINE_TEST(chip_label,
+              "gpiod_chip_label()",
               GU_LINES_UNNAMED, { 8, 8, 8 });
 
 static void chip_num_lines(void)
@@ -186,5 +189,6 @@ static void chip_num_lines(void)
        GU_ASSERT_EQ(gpiod_chip_num_lines(chip3), 16);
        GU_ASSERT_EQ(gpiod_chip_num_lines(chip4), 32);
 }
-GU_DEFINE_TEST(chip_num_lines, "chip_num_lines()",
+GU_DEFINE_TEST(chip_num_lines,
+              "gpiod_chip_num_lines()",
               GU_LINES_UNNAMED, { 1, 4, 8, 16, 32 });
index 719223297c82c07905c6bd702196348af23a0737..f727d6cfe8c1b73ae1564468897ea367bcceb1ea 100644 (file)
@@ -36,7 +36,8 @@ static void chip_iter(void)
        GU_ASSERT(B);
        GU_ASSERT(C);
 }
-GU_DEFINE_TEST(chip_iter, "gpiod_chip iterator",
+GU_DEFINE_TEST(chip_iter,
+              "gpiod_chip_iter - simple loop",
               GU_LINES_UNNAMED, { 8, 8, 8 });
 
 static void chip_iter_noclose(void)
@@ -84,7 +85,7 @@ static void chip_iter_noclose(void)
        GU_ASSERT_STR_EQ(gpiod_chip_label(chipC), "gpio-mockup-C");
 }
 GU_DEFINE_TEST(chip_iter_noclose,
-              "gpiod_chip iterator noclose",
+              "gpiod_chip_iter - simple loop, noclose variant",
               GU_LINES_UNNAMED, { 8, 8, 8 });
 
 static void line_iter(void)
@@ -107,7 +108,8 @@ static void line_iter(void)
 
        GU_ASSERT_EQ(8, i);
 }
-GU_DEFINE_TEST(line_iter, "line iterator",
+GU_DEFINE_TEST(line_iter,
+              "gpiod_line_iter - simple loop, check offsets",
               GU_LINES_UNNAMED, { 8 });
 
 static void line_iter_static_initializer(void)
@@ -132,5 +134,5 @@ static void line_iter_static_initializer(void)
        GU_ASSERT_EQ(8, i);
 }
 GU_DEFINE_TEST(line_iter_static_initializer,
-              "line iterator static initializer",
+              "gpiod_line_iter - simple loop, static initializer",
               GU_LINES_UNNAMED, { 8 });
index fc7274ca3870a15477244cf921e350162f6d7dc4..ae1f3d06bc169b9363adefc19037f4a8723945d2 100644 (file)
@@ -34,7 +34,7 @@ static void line_request_output(void)
        GU_ASSERT_EQ(gpiod_line_get_value(line_1), 1);
 }
 GU_DEFINE_TEST(line_request_output,
-              "line_request_output()",
+              "gpiod_line_request_output() - good",
               GU_LINES_UNNAMED, { 8 });
 
 static void line_request_bulk_output(void)
@@ -128,7 +128,7 @@ static void line_request_bulk_output(void)
        lineB0 = lineB1 = lineB2 = lineB3 = NULL;
 }
 GU_DEFINE_TEST(line_request_bulk_output,
-              "gpiod_line_request_bulk_output()",
+              "gpiod_line_request_bulk_output() - good",
               GU_LINES_UNNAMED, { 8, 8 });
 
 static void line_request_bulk_different_chips(void)
@@ -173,7 +173,7 @@ static void line_request_bulk_different_chips(void)
        GU_ASSERT_EQ(gpiod_errno(), GPIOD_EBULKINCOH);
 }
 GU_DEFINE_TEST(line_request_bulk_different_chips,
-              "gpiod_line_request_bulk() different chips",
+              "gpiod_line_request_bulk() different chips",
               GU_LINES_UNNAMED, { 8, 8 });
 
 static void line_set_value(void)
@@ -197,5 +197,5 @@ static void line_set_value(void)
        GU_ASSERT_EQ(gpiod_line_get_value(line), 0);
 }
 GU_DEFINE_TEST(line_set_value,
-              "line_set_value()",
+              "gpiod_line_set_value() - good",
               GU_LINES_UNNAMED, { 8 });
index b0a8f3efc6abc524c123753ec06a973024865e12..9efca8f7a0a479008e32cb6a61a99e02eaf4ae3d 100644 (file)
@@ -25,7 +25,7 @@ static void simple_set_get_value(void)
        GU_ASSERT_EQ(ret, 1);
 }
 GU_DEFINE_TEST(simple_set_get_value,
-              "simple set/get value",
+              "simple set/get value - single line",
               GU_LINES_UNNAMED, { 8 });
 
 static void simple_set_get_value_multiple(void)
@@ -80,7 +80,7 @@ static void simple_set_get_value_multiple(void)
        GU_ASSERT_EQ(values[9], 0);
 }
 GU_DEFINE_TEST(simple_set_get_value_multiple,
-              "simple set/get value multiple",
+              "simple set/get value - multiple lines",
               GU_LINES_UNNAMED, { 16 });
 
 static void simple_get_value_multiple_max_lines(void)
@@ -96,7 +96,7 @@ static void simple_get_value_multiple_max_lines(void)
        GU_ASSERT_EQ(gpiod_errno(), GPIOD_ELINEMAX);
 }
 GU_DEFINE_TEST(simple_get_value_multiple_max_lines,
-              "gpiod_simple_get_value_multiple() max lines",
+              "gpiod_simple_get_value_multiple() exceed max lines",
               GU_LINES_UNNAMED, { 128 });
 
 static void simple_set_value_multiple_max_lines(void)
@@ -112,5 +112,5 @@ static void simple_set_value_multiple_max_lines(void)
        GU_ASSERT_EQ(gpiod_errno(), GPIOD_ELINEMAX);
 }
 GU_DEFINE_TEST(simple_set_value_multiple_max_lines,
-              "gpiod_simple_set_value_multiple() max lines",
+              "gpiod_simple_set_value_multiple() exceed max lines",
               GU_LINES_UNNAMED, { 128 });