net: dpaa2-mac: use Autoneg bit rather than an_enabled
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 21 Mar 2023 15:58:44 +0000 (15:58 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Mar 2023 05:43:05 +0000 (22:43 -0700)
The Autoneg bit in the advertising bitmap and state->an_enabled are
always identical. Thus, we will be removing state->an_enabled.

Use the Autoneg bit in the advertising bitmap to indicate whether
autonegotiation should be used, rather than using the an_enabled
member which will be going away. This means we use the same condition
as phylink_mii_c22_pcs_config().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

index c886f33f8c6fee7fadb3bdf04deac3be8e20daf4..b1871e6c4006946995718dc4290281b01a11d45c 100644 (file)
@@ -159,7 +159,8 @@ static void dpaa2_mac_config(struct phylink_config *config, unsigned int mode,
        struct dpmac_link_state *dpmac_state = &mac->state;
        int err;
 
-       if (state->an_enabled)
+       if (linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
+                             state->advertising))
                dpmac_state->options |= DPMAC_LINK_OPT_AUTONEG;
        else
                dpmac_state->options &= ~DPMAC_LINK_OPT_AUTONEG;