rpmsg: Strcpy is not safe, use strscpy_pad() instead
authorSaud Farooqui <farooqui_saud@hotmail.com>
Thu, 23 Jun 2022 09:20:47 +0000 (14:20 +0500)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Fri, 24 Jun 2022 17:37:00 +0000 (11:37 -0600)
Replace strcpy() with strscpy_pad() for copying the rpmsg
device name in rpmsg_register_device_override().

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Saud Farooqui <farooqui_saud@hotmail.com>
Link: https://lore.kernel.org/r/PA4P189MB14210AA95DCA3715AFA7F4A68BB59@PA4P189MB1421.EURP189.PROD.OUTLOOK.COM
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/rpmsg/rpmsg_core.c

index 5a47cad89fdc31caf6c3d4ec356eaab22524bb54..d6dde00efdae673252f10b86197aa09923417e19 100644 (file)
@@ -604,7 +604,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev,
        int ret;
 
        if (driver_override)
-               strcpy(rpdev->id.name, driver_override);
+               strscpy_pad(rpdev->id.name, driver_override, RPMSG_NAME_SIZE);
 
        dev_set_name(dev, "%s.%s.%d.%d", dev_name(dev->parent),
                     rpdev->id.name, rpdev->src, rpdev->dst);