soundwire: cadence: adjust verbosity in response handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 15 Jan 2021 05:37:38 +0000 (13:37 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 19 Jan 2021 14:57:34 +0000 (20:27 +0530)
There are too many logs on startup, e.g.

[ 8811.851497] cdns_fill_msg_resp: 2 callbacks suppressed
[ 8811.851497] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851498] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851499] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851499] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851500] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851500] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851502] intel-sdw intel-sdw.0: Msg ignored for Slave 0
[ 8811.851503] soundwire sdw-master-0: No more devices to enumerate

We can skip the 'Msg Ack not received' since it's typical of the
enumeration end, and conversely add the information on which command
fails.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210115053738.22630-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c

index be6c9eaacef91ae8be338342101d1c0b41d0527c..d05442e646a38317c125ef5e9bf5606deff1c130 100644 (file)
@@ -483,11 +483,11 @@ cdns_fill_msg_resp(struct sdw_cdns *cdns,
        for (i = 0; i < count; i++) {
                if (!(cdns->response_buf[i] & CDNS_MCP_RESP_ACK)) {
                        no_ack = 1;
-                       dev_dbg_ratelimited(cdns->dev, "Msg Ack not received\n");
+                       dev_vdbg(cdns->dev, "Msg Ack not received, cmd %d\n", i);
                }
                if (cdns->response_buf[i] & CDNS_MCP_RESP_NACK) {
                        nack = 1;
-                       dev_err_ratelimited(cdns->dev, "Msg NACK received\n");
+                       dev_err_ratelimited(cdns->dev, "Msg NACK received, cmd %d\n", i);
                }
        }