leds: lp50xx: Don't spam logs when probe is deferred
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 16 Feb 2021 15:50:44 +0000 (17:50 +0200)
committerPavel Machek <pavel@ucw.cz>
Fri, 19 Feb 2021 21:15:31 +0000 (22:15 +0100)
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-lp50xx.c

index f13117eed976d90e792d990e55caf304765305b4..a2d18ec8fd2b9b57d06a6c002e9358867dff2964 100644 (file)
@@ -455,12 +455,9 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
        int i = 0;
 
        priv->enable_gpio = devm_gpiod_get_optional(priv->dev, "enable", GPIOD_OUT_LOW);
-       if (IS_ERR(priv->enable_gpio)) {
-               ret = PTR_ERR(priv->enable_gpio);
-               dev_err(&priv->client->dev, "Failed to get enable gpio: %d\n",
-                       ret);
-               return ret;
-       }
+       if (IS_ERR(priv->enable_gpio))
+               return dev_err_probe(priv->dev, PTR_ERR(priv->enable_gpio),
+                                    "Failed to get enable GPIO\n");
 
        priv->regulator = devm_regulator_get(priv->dev, "vled");
        if (IS_ERR(priv->regulator))