staging: r8188eu: do not spam the kernel log
authorMichael Straube <straube.linux@gmail.com>
Mon, 8 Aug 2022 06:50:23 +0000 (08:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2022 13:18:45 +0000 (15:18 +0200)
Drivers should not spam the kernel log if they work properly. Convert
the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use
netdev_dbg() instead of pr_info() so that developers can still enable
it if they want to see this information.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220808065023.3175-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
drivers/staging/r8188eu/os_dep/os_intfs.c

index 1fc4ba45bf31d1ae1cac037764fd3c8f8206c62f..158260547f2b27942032364385cc4c780a120251 100644 (file)
@@ -683,6 +683,7 @@ Hal_EfuseParseIDCode88E(
        )
 {
        struct eeprom_priv *pEEPROM = &padapter->eeprompriv;
+       struct net_device *netdev = padapter->pnetdev;
        u16                     EEPROMId;
 
        /*  Check 0x8129 again for making sure autoload status!! */
@@ -694,7 +695,7 @@ Hal_EfuseParseIDCode88E(
                pEEPROM->bautoload_fail_flag = false;
        }
 
-       pr_info("EEPROM ID = 0x%04x\n", EEPROMId);
+       netdev_dbg(netdev, "EEPROM ID = 0x%04x\n", EEPROMId);
 }
 
 static void Hal_ReadPowerValueFromPROM_8188E(struct txpowerinfo24g *pwrInfo24G, u8 *PROMContent, bool AutoLoadFail)
index cac9553666e6df97dc5f7a24126bd6d3b4199174..22e91657f3fbd911bd9567fe92ddd7d2e4cd2d2c 100644 (file)
@@ -635,7 +635,7 @@ int _netdev_open(struct net_device *pnetdev)
                if (status == _FAIL)
                        goto netdev_open_error;
 
-               pr_info("MAC Address = %pM\n", pnetdev->dev_addr);
+               netdev_dbg(pnetdev, "MAC Address = %pM\n", pnetdev->dev_addr);
 
                status = rtw_start_drv_threads(padapter);
                if (status == _FAIL) {