ext4: add missed brelse in update_backups
authorKemeng Shi <shikemeng@huaweicloud.com>
Sat, 26 Aug 2023 17:47:01 +0000 (01:47 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 6 Oct 2023 02:32:14 +0000 (22:32 -0400)
add missed brelse in update_backups

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Link: https://lore.kernel.org/r/20230826174712.4059355-3-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/resize.c

index 87cd5b07a97082f4cb6b03c771751e47260a736a..7cbc695b700527b58285521979c8d90c6a1ec4a0 100644 (file)
@@ -1191,8 +1191,10 @@ static void update_backups(struct super_block *sb, sector_t blk_off, char *data,
                           ext4_group_first_block_no(sb, group));
                BUFFER_TRACE(bh, "get_write_access");
                if ((err = ext4_journal_get_write_access(handle, sb, bh,
-                                                        EXT4_JTR_NONE)))
+                                                        EXT4_JTR_NONE))) {
+                       brelse(bh);
                        break;
+               }
                lock_buffer(bh);
                memcpy(bh->b_data, data, size);
                if (rest)