sched/numa: Document vma_numab_state fields
authorMel Gorman <mgorman@techsingularity.net>
Tue, 10 Oct 2023 08:31:38 +0000 (09:31 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Oct 2023 09:10:00 +0000 (11:10 +0200)
Document the intended usage of the fields.

[ mingo: Reformatted to take less vertical space & tidied it up. ]

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231010083143.19593-2-mgorman@techsingularity.net
include/linux/mm_types.h

index 36c5b43999e608a84fda4f34c07e0df3e7884ac3..d7f042ec1f339bd90cbde8b0d5bca44218e090eb 100644 (file)
@@ -551,8 +551,29 @@ struct vma_lock {
 };
 
 struct vma_numab_state {
+       /*
+        * Initialised as time in 'jiffies' after which VMA
+        * should be scanned.  Delays first scan of new VMA by at
+        * least sysctl_numa_balancing_scan_delay:
+        */
        unsigned long next_scan;
+
+       /*
+        * Time in jiffies when access_pids[] is reset to
+        * detect phase change behaviour:
+        */
        unsigned long next_pid_reset;
+
+       /*
+        * Approximate tracking of PIDs that trapped a NUMA hinting
+        * fault. May produce false positives due to hash collisions.
+        *
+        *   [0] Previous PID tracking
+        *   [1] Current PID tracking
+        *
+        * Window moves after next_pid_reset has expired approximately
+        * every VMA_PID_RESET_PERIOD jiffies:
+        */
        unsigned long access_pids[2];
 };