i2c: exynos5: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:35:55 +0000 (22:35 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:50 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-exynos5.c

index 385ef9d9e4d4c00547e69da0b64a56058b82e6e5..d8baca9b610c3b5a6d000978e5bcd162f05ba9ed 100644 (file)
@@ -763,7 +763,7 @@ static bool exynos5_i2c_poll_irqs_timeout(struct exynos5_i2c *i2c,
 static int exynos5_i2c_xfer_msg(struct exynos5_i2c *i2c,
                              struct i2c_msg *msgs, int stop)
 {
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        i2c->msg = msgs;
@@ -775,13 +775,13 @@ static int exynos5_i2c_xfer_msg(struct exynos5_i2c *i2c,
        exynos5_i2c_message_start(i2c, stop);
 
        if (!i2c->atomic)
-               timeout = wait_for_completion_timeout(&i2c->msg_complete,
-                                                     EXYNOS5_I2C_TIMEOUT);
-       else
-               timeout = exynos5_i2c_poll_irqs_timeout(i2c,
+               time_left = wait_for_completion_timeout(&i2c->msg_complete,
                                                        EXYNOS5_I2C_TIMEOUT);
+       else
+               time_left = exynos5_i2c_poll_irqs_timeout(i2c,
+                                                         EXYNOS5_I2C_TIMEOUT);
 
-       if (timeout == 0)
+       if (time_left == 0)
                ret = -ETIMEDOUT;
        else
                ret = i2c->state;