staging: r8188eu: always cancel blink_work when WPS failed
authorMartin Kaiser <martin@kaiser.cx>
Mon, 5 Sep 2022 20:01:44 +0000 (22:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Sep 2022 07:52:08 +0000 (09:52 +0200)
Cancel blink_work if WPS fails. Another worker will be scheduled after
the state variables are updated.

Tested-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220905200146.82259-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 4841bb2898ba76b4e91b5e7fa16ec6a79b00f3d3..80d9d8184fcd0b88a509ff12ea97f25dfb683b5a 100644 (file)
@@ -357,8 +357,8 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
                }
                break;
        case LED_CTL_STOP_WPS_FAIL:
+               cancel_delayed_work(&pLed->blink_work);
                if (pLed->bLedWPSBlinkInProgress) {
-                       cancel_delayed_work(&pLed->blink_work);
                        pLed->bLedWPSBlinkInProgress = false;
                }
                pLed->bLedNoLinkBlinkInProgress = true;