tty: Cleanup tty_port_set_active() bool parameter

Make callers pass true/false consistently for bool val.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230117090358.4796-4-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index f8cdce1626cbb22c29ce764609ac6fcc435707cb..460d33a1e70be90a62136fccbf3817c63e209d68 100644 (file)
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -1329,7 +1329,7 @@ static void rs_hangup(struct tty_struct *tty)
        rs_flush_buffer(tty);
        shutdown(tty, info);
        info->tport.count = 0;
-       tty_port_set_active(&info->tport, 0);
+       tty_port_set_active(&info->tport, false);
        info->tport.tty = NULL;
        wake_up_interruptible(&info->tport.open_wait);
 }

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index b06879af2248adac181b81acdc0b40f084ec0441..7752bdb680e79fce5003572db9fcb629754540bf 100644 (file)
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1827,7 +1827,7 @@ static void uart_hangup(struct tty_struct *tty)
                spin_lock_irqsave(&port->lock, flags);
                port->count = 0;
                spin_unlock_irqrestore(&port->lock, flags);
-               tty_port_set_active(port, 0);
+               tty_port_set_active(port, false);
                tty_port_tty_set(port, NULL);
                if (uport && !uart_console(uport))
                        uart_change_pm(state, UART_PM_STATE_OFF);
@@ -1945,7 +1945,7 @@ static int uart_port_activate(struct tty_port *port, struct tty_struct *tty)
         */
        ret = uart_startup(tty, state, 0);
        if (ret > 0)
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
 
        return ret;
 }

diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
index 2b96bf0ecafbf9bef4625659dd6232f2269287f1..81c94906f06ec3ac4fb7af595955472c304d0c1e 100644 (file)
--- a/drivers/tty/synclink_gt.c
+++ b/drivers/tty/synclink_gt.c
@@ -694,7 +694,7 @@ static void hangup(struct tty_struct *tty)
        info->port.count = 0;
        info->port.tty = NULL;
        spin_unlock_irqrestore(&info->port.lock, flags);
-       tty_port_set_active(&info->port, 0);
+       tty_port_set_active(&info->port, false);
        mutex_unlock(&info->port.mutex);
 
        wake_up_interruptible(&info->port.open_wait);
@@ -3169,7 +3169,7 @@ static int block_til_ready(struct tty_struct *tty, struct file *filp,
 
        if (filp->f_flags & O_NONBLOCK || tty_io_error(tty)) {
                /* nonblock mode is set or port is not enabled */
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
                return 0;
        }
 
@@ -3226,7 +3226,7 @@ static int block_til_ready(struct tty_struct *tty, struct file *filp,
        port->blocked_open--;
 
        if (!retval)
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
 
        DBGINFO(("%s block_til_ready ready, rc=%d\n", tty->driver->name, retval));
        return retval;

diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index 0c00d5bd6c886f646766084c2539f3914e6ce5e0..469de3c010b8b69e071f9de1a12fc5496ddb7622 100644 (file)
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -403,7 +403,7 @@ void tty_port_hangup(struct tty_port *port)
                set_bit(TTY_IO_ERROR, &tty->flags);
        port->tty = NULL;
        spin_unlock_irqrestore(&port->lock, flags);
-       tty_port_set_active(port, 0);
+       tty_port_set_active(port, false);
        tty_port_shutdown(port, tty);
        tty_kref_put(tty);
        wake_up_interruptible(&port->open_wait);
@@ -518,14 +518,14 @@ int tty_port_block_til_ready(struct tty_port *port,
         * the port has just hung up or is in another error state.
         */
        if (tty_io_error(tty)) {
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
                return 0;
        }
        if (filp == NULL || (filp->f_flags & O_NONBLOCK)) {
                /* Indicate we are open */
                if (C_BAUD(tty))
                        tty_port_raise_dtr_rts(port);
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
                return 0;
        }
 
@@ -588,7 +588,7 @@ int tty_port_block_til_ready(struct tty_port *port,
        port->blocked_open--;
        spin_unlock_irqrestore(&port->lock, flags);
        if (retval == 0)
-               tty_port_set_active(port, 1);
+               tty_port_set_active(port, true);
        return retval;
 }
 EXPORT_SYMBOL(tty_port_block_til_ready);
@@ -695,7 +695,7 @@ void tty_port_close_end(struct tty_port *port, struct tty_struct *tty)
                wake_up_interruptible(&port->open_wait);
        }
        spin_unlock_irqrestore(&port->lock, flags);
-       tty_port_set_active(port, 0);
+       tty_port_set_active(port, false);
 }
 EXPORT_SYMBOL(tty_port_close_end);