arm64: dts: qcom: pmi8994: Remove hardcoded linear WLED enabled-strings
authorMarijn Suijten <marijn.suijten@somainline.org>
Thu, 7 Oct 2021 21:33:58 +0000 (23:33 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Sun, 24 Oct 2021 18:04:04 +0000 (13:04 -0500)
The driver now sets an appropriate default for WLED4 (and WLED5) just
like WLED3 making this linear array from 0-3 redundant.  In addition the
driver is now able to parse arrays of variable length solving the "all
four strings *have to* be defined" comment.

Besides the driver will now warn when both properties are specified to
prevent ambiguity: the length of the array is enough to imply a set
number of strings.

Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-By: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20211007213400.258371-12-marijn.suijten@somainline.org
arch/arm64/boot/dts/qcom/pmi8994.dtsi

index a06ea9adae8109e13698ead7e13a95ee4def3296..89ba4146e7474af1cdbbfd0528415febc2f4fe33 100644 (file)
@@ -39,8 +39,6 @@
                        interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
                        interrupt-names = "short";
                        qcom,num-strings = <3>;
-                       /* Yes, all four strings *have to* be defined or things won't work. */
-                       qcom,enabled-strings = <0 1 2 3>;
                        qcom,cabc;
                        qcom,external-pfet;
                        status = "disabled";