serial: pch: remove debug print from pop_tx
authorJiri Slaby <jslaby@suse.cz>
Tue, 3 May 2022 08:08:05 +0000 (10:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 May 2022 20:42:46 +0000 (22:42 +0200)
It makes the code overly complicated for no good reason.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220503080808.28332-3-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c

index 4fcb6c144b548d170d06467c4235e04596758b4b..a90bdff609089b400fe00200b68eeee898bb6122 100644 (file)
@@ -764,7 +764,7 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size)
        struct circ_buf *xmit = &port->state->xmit;
 
        if (uart_tx_stopped(port))
-               goto pop_tx_end;
+               return false;
 
        while (!uart_circ_empty(xmit) && count < size) {
                iowrite8(xmit->buf[xmit->tail], priv->membase + PCH_UART_THR);
@@ -773,10 +773,6 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size)
                count++;
        }
 
-pop_tx_end:
-       dev_dbg(priv->port.dev, "%d characters. Remained %d characters.(%lu)\n",
-                count, size - count, jiffies);
-
        return count;
 }