staging: greybus: pwm: Rely on pwm framework to pass a valid hwpwm
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 14 Feb 2024 09:33:24 +0000 (10:33 +0100)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 22 Feb 2024 13:39:28 +0000 (14:39 +0100)
The pwm framework already asserts to only pass a hwpwm value (= which)
less than npwm (= pwmc->pwm_max + 1). So there is no need to recheck
this condition. Drop the respective checks.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/e003bc5e8e66f27f2b8fdc525a536d865888cffe.1707900770.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/staging/greybus/pwm.c

index 0cd1dab2d888c511239692f9ab520dc53f2a0953..3099c2a3611cabc3e245fb45993275c8363d12e7 100644 (file)
@@ -46,9 +46,6 @@ static int gb_pwm_activate_operation(struct pwm_chip *chip, u8 which)
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
 
        gbphy_dev = to_gbphy_dev(pwmchip_parent(chip));
@@ -71,9 +68,6 @@ static int gb_pwm_deactivate_operation(struct pwm_chip *chip, u8 which)
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
 
        gbphy_dev = to_gbphy_dev(pwmchip_parent(chip));
@@ -97,9 +91,6 @@ static int gb_pwm_config_operation(struct pwm_chip *chip,
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
        request.duty = cpu_to_le32(duty);
        request.period = cpu_to_le32(period);
@@ -125,9 +116,6 @@ static int gb_pwm_set_polarity_operation(struct pwm_chip *chip,
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
        request.polarity = polarity;
 
@@ -151,9 +139,6 @@ static int gb_pwm_enable_operation(struct pwm_chip *chip, u8 which)
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
 
        gbphy_dev = to_gbphy_dev(pwmchip_parent(chip));
@@ -176,9 +161,6 @@ static int gb_pwm_disable_operation(struct pwm_chip *chip, u8 which)
        struct gbphy_device *gbphy_dev;
        int ret;
 
-       if (which > pwmc->pwm_max)
-               return -EINVAL;
-
        request.which = which;
 
        ret = gb_operation_sync(pwmc->connection, GB_PWM_TYPE_DISABLE,