hv_netvsc: fix error return code in netvsc_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 31 May 2018 02:04:43 +0000 (02:04 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Jun 2018 14:35:25 +0000 (10:35 -0400)
Fix to return a negative error code from the failover register fail
error handling case instead of 0, as done elsewhere in this function.

Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/netvsc_drv.c

index ebe964203effbb0c606c12e27d505835dd0b2924..bef4d55a108c1d14eae766b8bc75c179d675e2ad 100644 (file)
@@ -2031,8 +2031,10 @@ static int netvsc_probe(struct hv_device *dev,
        }
 
        net_device_ctx->failover = failover_register(net, &netvsc_failover_ops);
-       if (IS_ERR(net_device_ctx->failover))
+       if (IS_ERR(net_device_ctx->failover)) {
+               ret = PTR_ERR(net_device_ctx->failover);
                goto err_failover;
+       }
 
        return ret;