phy: rockchip: fix CONFIG_TYPEC dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 15 Apr 2024 17:42:25 +0000 (19:42 +0200)
committerVinod Koul <vkoul@kernel.org>
Wed, 17 Apr 2024 14:33:01 +0000 (20:03 +0530)
The newly added driver causes a warning about missing dependencies
by selecting CONFIG_TYPEC unconditionally:

WARNING: unmet direct dependencies detected for TYPEC
  Depends on [n]: USB_SUPPORT [=n]
  Selected by [y]:
  - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y]

WARNING: unmet direct dependencies detected for USB_COMMON
  Depends on [n]: USB_SUPPORT [=n]
  Selected by [y]:
  - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y]

Since that is a user-visible option, it should not really be selected
in the first place. Replace the 'select' with a 'depends on' as
we have for similar drivers.

Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240415174241.77982-1-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/Kconfig

index c3d62243b47438508345f3fb23f9e7f71cf88cfb..89ed32b3b12e66b0d00846a2191a106442eb2ac5 100644 (file)
@@ -119,8 +119,8 @@ config PHY_ROCKCHIP_USB
 config PHY_ROCKCHIP_USBDP
        tristate "Rockchip USBDP COMBO PHY Driver"
        depends on ARCH_ROCKCHIP && OF
+       depends on TYPEC
        select GENERIC_PHY
-       select TYPEC
        help
          Enable this to support the Rockchip USB3.0/DP combo PHY with
          Samsung IP block. This is required for USB3 support on RK3588.