usbip: Remove in_interrupt() check
authorAhmed S. Darwish <a.darwish@linutronix.de>
Mon, 19 Oct 2020 10:06:36 +0000 (12:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Oct 2020 12:06:06 +0000 (13:06 +0100)
The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

usbip_recv() uses in_interrupt() to conditionally print context information
for debugging messages. The value is zero as the function is only called
from various *_rx_loop() kthread functions. Remove it.

Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20201019101110.332963099@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/usbip_common.c

index 4ce6c6a45eb11a643f2677b21bf95f7c7d2f008d..2ab99244bc314dd42c0921105181fbbecdc3047e 100644 (file)
@@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void *buf, int size)
        } while (msg_data_left(&msg));
 
        if (usbip_dbg_flag_xmit) {
-               if (!in_interrupt())
-                       pr_debug("%-10s:", current->comm);
-               else
-                       pr_debug("interrupt  :");
-
                pr_debug("receiving....\n");
                usbip_dump_buffer(buf, size);
                pr_debug("received, osize %d ret %d size %zd total %d\n",