include/hw/i386: Don't include qemu-common.h in .h files
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 29 Nov 2021 20:05:07 +0000 (20:05 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Wed, 15 Dec 2021 10:35:26 +0000 (10:35 +0000)
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).

include/hw/i386/x86.h and include/hw/i386/microvm.h break this rule.
In fact, the include is not required at all, so we can just drop it
from both files.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20211129200510.1233037-2-peter.maydell@linaro.org

include/hw/i386/microvm.h
include/hw/i386/x86.h

index 4d9c732d4b2b28d997fa9270f200d5e2566c1974..efcbd926fd43e048396e932d6ae1741ead0444d2 100644 (file)
@@ -18,7 +18,6 @@
 #ifndef HW_I386_MICROVM_H
 #define HW_I386_MICROVM_H
 
-#include "qemu-common.h"
 #include "exec/hwaddr.h"
 #include "qemu/notify.h"
 
index bb1cfb8896643155e150bae671ffa9ad6fab5c19..a145a303703f32a3a8200386cd678cacac0f5f5c 100644 (file)
@@ -17,7 +17,6 @@
 #ifndef HW_I386_X86_H
 #define HW_I386_X86_H
 
-#include "qemu-common.h"
 #include "exec/hwaddr.h"
 #include "qemu/notify.h"