media: entity: Add link_type_name() helper
authorDaniel Scally <djrscally@gmail.com>
Wed, 2 Mar 2022 22:03:02 +0000 (22:03 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 06:58:44 +0000 (07:58 +0100)
Now we have three types of media link, printing the right name during
debug output is slightly more complicated. Add a helper function to
make it easier.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/mc/mc-entity.c

index 379898ca704c73e1982ff19b122add6e43d44894..4b616b11d8e4c3f66bc320340c34b566d28fd86c 100644 (file)
@@ -44,6 +44,20 @@ static inline const char *intf_type(struct media_interface *intf)
        }
 };
 
+static inline const char *link_type_name(struct media_link *link)
+{
+       switch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {
+       case MEDIA_LNK_FL_DATA_LINK:
+               return "data";
+       case MEDIA_LNK_FL_INTERFACE_LINK:
+               return "interface";
+       case MEDIA_LNK_FL_ANCILLARY_LINK:
+               return "ancillary";
+       default:
+               return "unknown";
+       }
+}
+
 __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,
                                          int idx_max)
 {
@@ -89,9 +103,7 @@ static void dev_dbg_obj(const char *event_name,  struct media_gobj *gobj)
 
                dev_dbg(gobj->mdev->dev,
                        "%s id %u: %s link id %u ==> id %u\n",
-                       event_name, media_id(gobj),
-                       media_type(link->gobj0) == MEDIA_GRAPH_PAD ?
-                               "data" : "interface",
+                       event_name, media_id(gobj), link_type_name(link),
                        media_id(link->gobj0),
                        media_id(link->gobj1));
                break;