bus: sunxi-rsb: Remove dev_err() usage after platform_get_irq()
authorStephen Boyd <swboyd@chromium.org>
Tue, 30 Jul 2019 18:15:02 +0000 (11:15 -0700)
committerChen-Yu Tsai <wens@csie.org>
Tue, 6 Aug 2019 06:15:49 +0000 (14:15 +0800)
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
drivers/bus/sunxi-rsb.c

index 1b76d958590275daa6b9c2f8c69ecd2d51655da7..be79d6c6a4e458bc330467af1c0e150125526242 100644 (file)
@@ -651,10 +651,8 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
                return PTR_ERR(rsb->regs);
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "failed to retrieve irq: %d\n", irq);
+       if (irq < 0)
                return irq;
-       }
 
        rsb->clk = devm_clk_get(dev, NULL);
        if (IS_ERR(rsb->clk)) {