wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and RTL8851B

The if statement is reversed so it will not record the chip version.
This was detected using Smatch:

    drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver()
    error: uninitialized symbol 'val'.

Fixes: a6fb2bb84654 ("wifi: rtw89: read version of analog hardware")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/e4d912a2-37f8-4068-8861-7b9494ae731b@kili.mountain

diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index c376dae916e700f2581e98e9d231077030494c68..630124f9e025436f93dea391ee32039d56dd2c55 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -3668,7 +3668,7 @@ static void rtw89_read_chip_ver(struct rtw89_dev *rtwdev)
 
        if (chip->chip_id == RTL8852B || chip->chip_id == RTL8851B) {
                ret = rtw89_mac_read_xtal_si(rtwdev, XTAL_SI_CV, &val);
-               if (!ret)
+               if (ret)
                        return;
 
                rtwdev->hal.acv = u8_get_bits(val, XTAL_SI_ACV_MASK);