KVM: x86: Remove redundant vcpu->arch.cr0 assignments
authorMichal Luczaj <mhal@rbox.co>
Mon, 14 Aug 2023 22:08:35 +0000 (00:08 +0200)
committerSean Christopherson <seanjc@google.com>
Wed, 27 Sep 2023 19:57:48 +0000 (12:57 -0700)
Drop the vcpu->arch.cr0 assignment after static_call(kvm_x86_set_cr0).
CR0 was already set by {vmx,svm}_set_cr0().

Signed-off-by: Michal Luczaj <mhal@rbox.co>
Link: https://lore.kernel.org/r/20230814222358.707877-2-mhal@rbox.co
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/smm.c
arch/x86/kvm/x86.c

index b42111a24cc28de2b680b9b495d6f3cb256541ef..dc3d95fdca7d337ef4305123b8f439d2103c8b30 100644 (file)
@@ -324,7 +324,6 @@ void enter_smm(struct kvm_vcpu *vcpu)
 
        cr0 = vcpu->arch.cr0 & ~(X86_CR0_PE | X86_CR0_EM | X86_CR0_TS | X86_CR0_PG);
        static_call(kvm_x86_set_cr0)(vcpu, cr0);
-       vcpu->arch.cr0 = cr0;
 
        static_call(kvm_x86_set_cr4)(vcpu, 0);
 
index 9f18b06bbda66bf411bb492fa4ab4c5fd9e90080..d960d4094a0bf5e3e8e81aa2dd38b0ebb2f1d61e 100644 (file)
@@ -11521,7 +11521,6 @@ static int __set_sregs_common(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs,
 
        *mmu_reset_needed |= kvm_read_cr0(vcpu) != sregs->cr0;
        static_call(kvm_x86_set_cr0)(vcpu, sregs->cr0);
-       vcpu->arch.cr0 = sregs->cr0;
 
        *mmu_reset_needed |= kvm_read_cr4(vcpu) != sregs->cr4;
        static_call(kvm_x86_set_cr4)(vcpu, sregs->cr4);