md: clean up invalid BUG_ON in md_ioctl
authorLi Nan <linan122@huawei.com>
Mon, 26 Feb 2024 03:14:38 +0000 (11:14 +0800)
committerSong Liu <song@kernel.org>
Mon, 26 Feb 2024 18:22:22 +0000 (10:22 -0800)
'disk->private_data' is set to mddev in md_alloc() and never set to NULL,
and users need to open mddev before submitting ioctl. So mddev must not
have been freed during ioctl, and there is no need to check mddev here.
Clean up it.

Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240226031444.3606764-4-linan666@huaweicloud.com
drivers/md/md.c

index 3c8a0784cf6ac0cf13bef7a08b4192a3369a855b..08170902d3424436d722215b78036efb28e260ad 100644 (file)
@@ -7622,11 +7622,6 @@ static int md_ioctl(struct block_device *bdev, blk_mode_t mode,
 
        mddev = bdev->bd_disk->private_data;
 
-       if (!mddev) {
-               BUG();
-               goto out;
-       }
-
        /* Some actions do not requires the mutex */
        switch (cmd) {
        case GET_ARRAY_INFO: