ui: Improve a client_migrate_info error message
authorMarkus Armbruster <armbru@redhat.com>
Fri, 13 Nov 2020 08:26:21 +0000 (09:26 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 10 Dec 2020 16:16:44 +0000 (17:16 +0100)
client_migrate_info reports spice_server_migrate_connect() failure as
"An undefined error has occurred".  Improve to "Could not set up
display for migration".

QERR_UNDEFINED_ERROR is now unused.  Drop.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201113082626.2725812-6-armbru@redhat.com>

include/qapi/qmp/qerror.h
monitor/misc.c

index d8267129bcfb950e9f4adb66b3bcd153ed879a4e..596fce0c54e7de96a0dd5afa4627565caaf0f201 100644 (file)
@@ -65,9 +65,6 @@
 #define QERR_REPLAY_NOT_SUPPORTED \
     "Record/replay feature is not supported for '%s'"
 
-#define QERR_UNDEFINED_ERROR \
-    "An undefined error has occurred"
-
 #define QERR_UNSUPPORTED \
     "this feature or command is not currently supported"
 
index c563e901c0de00c188a625b42dcb1c8b2778fa4d..bb102df82371165151a7cc5c6ef6fb2ebce8889e 100644 (file)
@@ -441,7 +441,7 @@ void qmp_client_migrate_info(const char *protocol, const char *hostname,
                                     has_port ? port : -1,
                                     has_tls_port ? tls_port : -1,
                                     cert_subject)) {
-            error_setg(errp, QERR_UNDEFINED_ERROR);
+            error_setg(errp, "Could not set up display for migration");
             return;
         }
         return;