staging: comedi: das800: fix request_irq() warn
authorTong Zhang <ztong0001@gmail.com>
Fri, 19 Mar 2021 03:47:52 +0000 (23:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Mar 2021 16:04:11 +0000 (17:04 +0100)
request_irq() won't accept a name which contains slash so we need to
replace it with something else -- otherwise it will throw a warning
and the entry in /proc/irq/ will not be created.
Since the .name might be used by userspace and we don't want to break
userspace, so we are changing the parameters passed to request_irq()

Suggested-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Link: https://lore.kernel.org/r/20210319034753.435811-1-ztong0001@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/das800.c

index 2881808d6606c2833ada99de22428aa4265a8d5a..bc08324f422faf3f1df19c44dbf043e9ed871c12 100644 (file)
@@ -668,7 +668,7 @@ static int das800_attach(struct comedi_device *dev, struct comedi_devconfig *it)
        dev->board_name = board->name;
 
        if (irq > 1 && irq <= 7) {
-               ret = request_irq(irq, das800_interrupt, 0, dev->board_name,
+               ret = request_irq(irq, das800_interrupt, 0, "das800",
                                  dev);
                if (ret == 0)
                        dev->irq = irq;