platform/x86: sel3350-platform: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230927081040.2198742-23-u.kleine-koenig@pengutronix.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/sel3350-platform.c b/drivers/platform/x86/sel3350-platform.c
index fa267d0d377815039de3d0afb9d14ab2a25c47df..d09e976e71483203e7e443114827660ece987e95 100644 (file)
--- a/drivers/platform/x86/sel3350-platform.c
+++ b/drivers/platform/x86/sel3350-platform.c
@@ -218,15 +218,13 @@ err_platform:
        return rs;
 }
 
-static int sel3350_remove(struct platform_device *pdev)
+static void sel3350_remove(struct platform_device *pdev)
 {
        struct sel3350_data *sel3350 = platform_get_drvdata(pdev);
 
        platform_device_unregister(sel3350->leds_pdev);
        gpiod_remove_lookup_table(&sel3350_gpios_table);
        gpiod_remove_lookup_table(&sel3350_leds_table);
-
-       return 0;
 }
 
 static const struct acpi_device_id sel3350_device_ids[] = {
@@ -237,7 +235,7 @@ MODULE_DEVICE_TABLE(acpi, sel3350_device_ids);
 
 static struct platform_driver sel3350_platform_driver = {
        .probe = sel3350_probe,
-       .remove = sel3350_remove,
+       .remove_new = sel3350_remove,
        .driver = {
                .name = "sel3350-platform",
                .acpi_match_table = sel3350_device_ids,