xfrm: espintcp: save and call old ->sk_destruct

When ESP encapsulation is enabled on a TCP socket, I'm replacing the
existing ->sk_destruct callback with espintcp_destruct. We still need to
call the old callback to perform the other cleanups when the socket is
destroyed. Save the old callback, and call it from espintcp_destruct.

Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

diff --git a/include/net/espintcp.h b/include/net/espintcp.h
index dd7026a000660e9890a50c9846d1027476be4fb6..0335bbd76552a1ab0b509ef051536c097c8a2615 100644 (file)
--- a/include/net/espintcp.h
+++ b/include/net/espintcp.h
@@ -25,6 +25,7 @@ struct espintcp_ctx {
        struct espintcp_msg partial;
        void (*saved_data_ready)(struct sock *sk);
        void (*saved_write_space)(struct sock *sk);
+       void (*saved_destruct)(struct sock *sk);
        struct work_struct work;
        bool tx_running;
 };

diff --git a/net/xfrm/espintcp.c b/net/xfrm/espintcp.c
index 037ea156d2f93b5e0f5611f884f766cacfaefff9..5a0ff665b71a8dd4125827b13fcd8c3263e74142 100644 (file)
--- a/net/xfrm/espintcp.c
+++ b/net/xfrm/espintcp.c
@@ -379,6 +379,7 @@ static void espintcp_destruct(struct sock *sk)
 {
        struct espintcp_ctx *ctx = espintcp_getctx(sk);
 
+       ctx->saved_destruct(sk);
        kfree(ctx);
 }
 
@@ -419,6 +420,7 @@ static int espintcp_init_sk(struct sock *sk)
        sk->sk_socket->ops = &espintcp_ops;
        ctx->saved_data_ready = sk->sk_data_ready;
        ctx->saved_write_space = sk->sk_write_space;
+       ctx->saved_destruct = sk->sk_destruct;
        sk->sk_data_ready = espintcp_data_ready;
        sk->sk_write_space = espintcp_write_space;
        sk->sk_destruct = espintcp_destruct;