projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eb32cfc
)
net: fujitsu: fix a potential NULL pointer dereference
author
Kangjie Lu
<kjlu@umn.edu>
Tue, 12 Mar 2019 07:16:21 +0000
(
02:16
-0500)
committer
David S. Miller
<davem@davemloft.net>
Tue, 12 Mar 2019 21:48:35 +0000
(14:48 -0700)
In case ioremap fails, the fix releases the pcmcia window and
returns -ENOMEM to avoid the NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/fujitsu/fmvj18x_cs.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
b/drivers/net/ethernet/fujitsu/fmvj18x_cs.c
index a69cd19a55ae2f018cf5340f0f2680bff5f36c86..1eca0fdb99334a24e4b33b709118ecaad93b1f06 100644
(file)
--- a/
drivers/net/ethernet/fujitsu/fmvj18x_cs.c
+++ b/
drivers/net/ethernet/fujitsu/fmvj18x_cs.c
@@
-547,6
+547,11
@@
static int fmvj18x_get_hwinfo(struct pcmcia_device *link, u_char *node_id)
return -1;
base = ioremap(link->resource[2]->start, resource_size(link->resource[2]));
+ if (!base) {
+ pcmcia_release_window(link, link->resource[2]);
+ return -ENOMEM;
+ }
+
pcmcia_map_mem_page(link, link->resource[2], 0);
/*