drm/panfrost: Make ->run_job() return an ERR_PTR() when appropriate
authorBoris Brezillon <boris.brezillon@collabora.com>
Wed, 30 Jun 2021 06:27:38 +0000 (08:27 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Thu, 1 Jul 2021 06:53:27 +0000 (08:53 +0200)
If the fence creation fail, we can return the error pointer directly.
The core will update the fence error accordingly.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210630062751.2832545-4-boris.brezillon@collabora.com
drivers/gpu/drm/panfrost/panfrost_job.c

index 17bc5e3bfe0e0ae82009245888e4f05efdba06f9..3c1dbae3ebdd1f583c93271ba58bf7ea3a49e1ac 100644 (file)
@@ -344,7 +344,7 @@ static struct dma_fence *panfrost_job_run(struct drm_sched_job *sched_job)
 
        fence = panfrost_fence_create(pfdev, slot);
        if (IS_ERR(fence))
-               return NULL;
+               return fence;
 
        if (job->done_fence)
                dma_fence_put(job->done_fence);