mfd: motorola-cpcap: Drop unnecessary of_match_device() call
authorRob Herring <robh@kernel.org>
Tue, 17 Oct 2023 20:35:36 +0000 (15:35 -0500)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 10:02:16 +0000 (10:02 +0000)
If probe is reached, we've already matched the device and in the case of
DT matching, the struct device_node pointer will be set. Therefore, there
is no need to call of_match_device() in probe.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20231017203537.2700340-1-robh@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/motorola-cpcap.c

index a19691ba8d8b08c1f47205a67449ebefdd9468c7..d8243b956f875df31a92834049e1aad7b1cdb77b 100644 (file)
@@ -11,7 +11,7 @@
 #include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/regmap.h>
 #include <linux/sysfs.h>
 
@@ -290,14 +290,9 @@ static const struct mfd_cell cpcap_mfd_devices[] = {
 
 static int cpcap_probe(struct spi_device *spi)
 {
-       const struct of_device_id *match;
        struct cpcap_ddata *cpcap;
        int ret;
 
-       match = of_match_device(cpcap_of_match, &spi->dev);
-       if (!match)
-               return -ENODEV;
-
        cpcap = devm_kzalloc(&spi->dev, sizeof(*cpcap), GFP_KERNEL);
        if (!cpcap)
                return -ENOMEM;