tests/functional: honour requested test VM name in QEMUMachine
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 21 Nov 2024 16:57:37 +0000 (16:57 +0000)
committerAlex Bennée <alex.bennee@linaro.org>
Mon, 25 Nov 2024 10:06:20 +0000 (10:06 +0000)
The functional test case class is going to the trouble of passing
around a machine name, but then fails to give this QEMUMachine. As
a result, QEMUMachine will create a completely random name. Since
log file names match the machine name, this results in log files
accumulating over time.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20241121154218.1423005-11-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241121165806.476008-11-alex.bennee@linaro.org>

tests/functional/qemu_test/testcase.py

index ca13af244b6b826f6963e2d07501132ac1aed5f0..f9c9de116694bcb89f83a40c3b36a6fcec2e94e8 100644 (file)
@@ -164,6 +164,7 @@ class QemuSystemTest(QemuBaseTest):
 
     def _new_vm(self, name, *args):
         vm = QEMUMachine(self.qemu_bin,
+                         name=name,
                          base_temp_dir=self.workdir,
                          log_dir=self.logdir)
         self.log.debug('QEMUMachine "%s" created', name)