staging: pi433: use DEFINE_SHOW_ATTRIBUTE to simplify pi433_debugfs_regs
authorLiu Shixin <liushixin2@huawei.com>
Thu, 22 Sep 2022 14:25:48 +0000 (22:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 11:05:41 +0000 (13:05 +0200)
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Link: https://lore.kernel.org/r/20220922142548.3248951-1-liushixin2@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/pi433/pi433_if.c

index df02335fdbab8f243a59088e50006e338e9c1403..d4e06a3929f3d8e236e1c024108f4f0015f1c087 100644 (file)
@@ -1149,19 +1149,7 @@ out_unlock:
 
        return ret;
 }
-
-static int pi433_debugfs_regs_open(struct inode *inode, struct file *filp)
-{
-       return single_open(filp, pi433_debugfs_regs_show, inode->i_private);
-}
-
-static const struct file_operations debugfs_fops = {
-       .llseek =       seq_lseek,
-       .open =         pi433_debugfs_regs_open,
-       .owner =        THIS_MODULE,
-       .read =         seq_read,
-       .release =      single_release
-};
+DEFINE_SHOW_ATTRIBUTE(pi433_debugfs_regs);
 
 /*-------------------------------------------------------------------------*/
 
@@ -1320,7 +1308,7 @@ static int pi433_probe(struct spi_device *spi)
 
        entry = debugfs_create_dir(dev_name(device->dev),
                                   debugfs_lookup(KBUILD_MODNAME, NULL));
-       debugfs_create_file("regs", 0400, entry, device, &debugfs_fops);
+       debugfs_create_file("regs", 0400, entry, device, &pi433_debugfs_regs_fops);
 
        return 0;