cpufreq: vexpress: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c
index 865e501648034baf2e0c5f350ca65be820d049d3..9ac4ea50b8746f29c736e0e8c48d980e7737d203 100644 (file)
--- a/drivers/cpufreq/vexpress-spc-cpufreq.c
+++ b/drivers/cpufreq/vexpress-spc-cpufreq.c
@@ -551,7 +551,7 @@ static int ve_spc_cpufreq_probe(struct platform_device *pdev)
        return ret;
 }
 
-static int ve_spc_cpufreq_remove(struct platform_device *pdev)
+static void ve_spc_cpufreq_remove(struct platform_device *pdev)
 {
        bL_switcher_get_enabled();
        __bLs_unregister_notifier();
@@ -559,7 +559,6 @@ static int ve_spc_cpufreq_remove(struct platform_device *pdev)
        bL_switcher_put_enabled();
        pr_info("%s: Un-registered platform driver: %s\n", __func__,
                ve_spc_cpufreq_driver.name);
-       return 0;
 }
 
 static struct platform_driver ve_spc_cpufreq_platdrv = {
@@ -567,7 +566,7 @@ static struct platform_driver ve_spc_cpufreq_platdrv = {
                .name   = "vexpress-spc-cpufreq",
        },
        .probe          = ve_spc_cpufreq_probe,
-       .remove         = ve_spc_cpufreq_remove,
+       .remove_new     = ve_spc_cpufreq_remove,
 };
 module_platform_driver(ve_spc_cpufreq_platdrv);