staging: r8188eu: Use kmemdup() to replace kmalloc + memcpy
authorKai Song <songkai01@inspur.com>
Sun, 3 Oct 2021 07:28:41 +0000 (15:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Oct 2021 10:33:34 +0000 (12:33 +0200)
fix memdup.cocci warning:
drivers/staging/r8188eu/os_dep/ioctl_linux.c:4452:33-40: WARNING opportunity for kmemdup

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Kai Song <songkai01@inspur.com>
Link: https://lore.kernel.org/r/20211003072841.215903-1-songkai01@inspur.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/ioctl_linux.c

index 78c260d8372520f948fc0b2742f4b20ef2672d4a..e8fadbfcb3a9ca86bd743d6b0e6b93ea2cb5c782 100644 (file)
@@ -4183,12 +4183,11 @@ static int rtw_wx_set_priv(struct net_device *dev,
                        kfree(pmlmepriv->wps_probe_req_ie);
                        pmlmepriv->wps_probe_req_ie = NULL;
 
-                       pmlmepriv->wps_probe_req_ie = kmalloc(cp_sz, GFP_KERNEL);
+                       pmlmepriv->wps_probe_req_ie = kmemdup(probereq_wpsie, cp_sz, GFP_KERNEL);
                        if (!pmlmepriv->wps_probe_req_ie) {
                                ret =  -EINVAL;
                                goto FREE_EXT;
                        }
-                       memcpy(pmlmepriv->wps_probe_req_ie, probereq_wpsie, cp_sz);
                        pmlmepriv->wps_probe_req_ie_len = cp_sz;
                }
                goto FREE_EXT;