staging: rtl8192e: Use standard function in rtllib_rx_check_duplicate()
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Tue, 12 Sep 2023 19:28:25 +0000 (21:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Sep 2023 07:47:42 +0000 (09:47 +0200)
Use standard function ieee80211_is_beacon() to avoid proprietary code and
to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/b74b6ef5e266504b9e3d84495bcd8fe4978b4ded.1694546300.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_rx.c

index 89c8d66765fe37c939f59b491d755d115a7b5a7e..7c16d4db67ad2ecb8c147f541133ec696db36084 100644 (file)
@@ -904,11 +904,9 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
 {
        struct rtllib_hdr_4addr *hdr = (struct rtllib_hdr_4addr *)skb->data;
        u16 fc, sc;
-       u8 frag, type, stype;
+       u8 frag;
 
        fc = le16_to_cpu(hdr->frame_ctl);
-       type = WLAN_FC_GET_TYPE(fc);
-       stype = WLAN_FC_GET_STYPE(fc);
        sc = le16_to_cpu(hdr->seq_ctl);
        frag = WLAN_GET_SEQ_FRAG(sc);
 
@@ -916,8 +914,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
                !ieee->current_network.qos_data.active ||
                !IsDataFrame(skb->data) ||
                IsLegacyDataFrame(skb->data)) {
-               if (!((type == RTLLIB_FTYPE_MGMT) &&
-                     (stype == RTLLIB_STYPE_BEACON))) {
+               if (!ieee80211_is_beacon(hdr->frame_ctl)) {
                        if (is_duplicate_packet(ieee, hdr))
                                return -1;
                }