IB/core: Reorder GID delete code for RoCE
authorPatrisious Haddad <phaddad@nvidia.com>
Mon, 21 Nov 2022 09:59:28 +0000 (11:59 +0200)
committerLeon Romanovsky <leon@kernel.org>
Sun, 20 Aug 2023 09:35:24 +0000 (12:35 +0300)
Reorder GID delete code so that the driver del_gid operation is executed
before nullifying the gid attribute ndev parameter, this allows drivers
to access the ndev during their gid delete operation, which makes more
sense since they had access to it during the gid addition operation.

Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
drivers/infiniband/core/cache.c

index 2e91d88793265800acb86f6e8b9b320ccbc16be3..73f913cbd146a6090b1b89191fc51b93bcaa4481 100644 (file)
@@ -400,6 +400,9 @@ static void del_gid(struct ib_device *ib_dev, u32 port,
                table->data_vec[ix] = NULL;
        write_unlock_irq(&table->rwlock);
 
+       if (rdma_cap_roce_gid_table(ib_dev, port))
+               ib_dev->ops.del_gid(&entry->attr, &entry->context);
+
        ndev_storage = entry->ndev_storage;
        if (ndev_storage) {
                entry->ndev_storage = NULL;
@@ -407,9 +410,6 @@ static void del_gid(struct ib_device *ib_dev, u32 port,
                call_rcu(&ndev_storage->rcu_head, put_gid_ndev);
        }
 
-       if (rdma_cap_roce_gid_table(ib_dev, port))
-               ib_dev->ops.del_gid(&entry->attr, &entry->context);
-
        put_gid_entry_locked(entry);
 }