net: ipvtap: fix template string argument of device_create() call
authorJean Sacren <sakiwit@gmail.com>
Sat, 16 Oct 2021 05:41:35 +0000 (23:41 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Oct 2021 07:51:22 +0000 (08:51 +0100)
The last argument of device_create() call should be a template string.
The tap_name variable should be the argument to the string, but not the
argument of the call itself.  We should add the template string and turn
tap_name into its argument.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipvlan/ipvtap.c

index 1cedb634f4f7b67ed84cb337becff5263e37677b..ef02f2cf5ce13d9a3db210f83b801f1a3fde0976 100644 (file)
@@ -162,7 +162,7 @@ static int ipvtap_device_event(struct notifier_block *unused,
 
                devt = MKDEV(MAJOR(ipvtap_major), vlantap->tap.minor);
                classdev = device_create(&ipvtap_class, &dev->dev, devt,
-                                        dev, tap_name);
+                                        dev, "%s", tap_name);
                if (IS_ERR(classdev)) {
                        tap_free_minor(ipvtap_major, &vlantap->tap);
                        return notifier_from_errno(PTR_ERR(classdev));