staging: r8188eu: rx_packet_offset and max_recvbuf_sz are write-only
authorMichael Straube <straube.linux@gmail.com>
Fri, 28 Jan 2022 11:54:40 +0000 (12:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Jan 2022 12:56:24 +0000 (13:56 +0100)
The local variables rx_packet_offset and max_recvbuf_sz in
rtw_restructure_ht_ie() are set but never used. Remove them.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220128115445.6606-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme.c
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/hal_intf.h

index 6533a7babb65371cf4a54007fe3419a7fc9aeec8..094885c80a1a2f9e72f37ad607c8edb999c88cfc 100644 (file)
@@ -1901,7 +1901,6 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_
        struct mlme_priv        *pmlmepriv = &padapter->mlmepriv;
        struct qos_priv         *pqospriv = &pmlmepriv->qospriv;
        struct ht_priv          *phtpriv = &pmlmepriv->htpriv;
-       u32 rx_packet_offset, max_recvbuf_sz;
 
        phtpriv->ht_option = false;
 
@@ -1926,9 +1925,6 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_
                                                IEEE80211_HT_CAP_TX_STBC |
                                                IEEE80211_HT_CAP_DSSSCCK40);
 
-               GetHalDefVar8188EUsb(padapter, HAL_DEF_RX_PACKET_OFFSET, &rx_packet_offset);
-               GetHalDefVar8188EUsb(padapter, HAL_DEF_MAX_RECVBUF_SZ, &max_recvbuf_sz);
-
                /*
                AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
                AMPDU_para [4:2]:Min MPDU Start Spacing
index cc8f8c7d0734ed8e7a462e6745cf3d8e418f2255..d654d2f01c789520dd49c1e8e9f377cd30d16a16 100644 (file)
@@ -1625,12 +1625,6 @@ u8 GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable
        case HAL_DEF_DRVINFO_SZ:
                *((u32 *)pValue) = DRVINFO_SZ;
                break;
-       case HAL_DEF_MAX_RECVBUF_SZ:
-               *((u32 *)pValue) = MAX_RECVBUF_SZ;
-               break;
-       case HAL_DEF_RX_PACKET_OFFSET:
-               *((u32 *)pValue) = RXDESC_SIZE + DRVINFO_SZ;
-               break;
        case HAL_DEF_DBG_DM_FUNC:
                *((u32 *)pValue) = haldata->odmpriv.SupportAbility;
                break;
index 6728cb5063032c41fdd8c6ea187e47fb3b764454..726e60fd7273c1150890f213ae0c959bba3ea1c9 100644 (file)
@@ -76,8 +76,6 @@ enum hal_def_variable {
        HAL_DEF_IS_SUPPORT_ANT_DIV,
        HAL_DEF_CURRENT_ANTENNA,
        HAL_DEF_DRVINFO_SZ,
-       HAL_DEF_MAX_RECVBUF_SZ,
-       HAL_DEF_RX_PACKET_OFFSET,
        HAL_DEF_DBG_DUMP_RXPKT,/* for dbg */
        HAL_DEF_DBG_DM_FUNC,/* for dbg */
        HAL_DEF_RA_DECISION_RATE,