qcow2: Fix data file error condition in qcow2_co_create()
authorKevin Wolf <kwolf@redhat.com>
Wed, 13 Mar 2019 14:22:38 +0000 (15:22 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 19 Mar 2019 14:49:29 +0000 (15:49 +0100)
We were trying to check whether bdrv_open_blockdev_ref() returned
success, but accidentally checked the wrong variable. Spotted by
Coverity (CID 1399703).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
block/qcow2.c

index 0dd77c6367cd739235680723ea291ea682fe5569..d507ee0686f0b295f6a655dfe14be87f03c138fd 100644 (file)
@@ -3073,7 +3073,7 @@ qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp)
             goto out;
         }
         data_bs = bdrv_open_blockdev_ref(qcow2_opts->data_file, errp);
-        if (bs == NULL) {
+        if (data_bs == NULL) {
             ret = -EIO;
             goto out;
         }