regulator: axp20x: Fix misleading use of negation
authorOndrej Jirman <megous@megous.com>
Sat, 22 Feb 2020 23:56:34 +0000 (00:56 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 24 Feb 2020 13:41:35 +0000 (13:41 +0000)
It works incidentally, because AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN
is non-zero, but the false branch value really should be just 0.

Signed-off-by: Ondrej Jirman <megous@megous.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20200222235634.243805-1-megous@megous.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/axp20x-regulator.c

index 16f0c857003606958dd0f1a415d27327eb182847..1e6eb5b1f8d8527bd7bdcfb893f0729601130cf7 100644 (file)
@@ -381,8 +381,7 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
                        mask = AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_RATE_MASK |
                               AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN_MASK;
                        enable = (ramp > 0) ?
-                                AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN :
-                                !AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN;
+                                AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN : 0;
                        break;
                }
 
@@ -393,8 +392,7 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
                        mask = AXP20X_DCDC2_LDO3_V_RAMP_LDO3_RATE_MASK |
                               AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN_MASK;
                        enable = (ramp > 0) ?
-                                AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN :
-                                !AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN;
+                                AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN : 0;
                        break;
                }