media: Revert "media: rkisp1: Drop IRQF_SHARED"
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Mon, 18 Dec 2023 07:54:00 +0000 (08:54 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 1 Feb 2024 05:46:46 +0000 (06:46 +0100)
This reverts commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74.

The rkisp1 does share interrupt lines on some platforms, after all. Thus
we need to revert this, and implement a fix for the rkisp1 shared irq
handling in a follow-up patch.

Closes: https://lore.kernel.org/all/87o7eo8vym.fsf@gmail.com/
Link: https://lore.kernel.org/r/20231218-rkisp-shirq-fix-v1-1-173007628248@ideasonboard.com
Reported-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c

index f96f821a7b50d0f10db51932d2b82986dcb16957..acc559652d6ebae663993105af65e46c9ce5e321 100644 (file)
@@ -559,7 +559,7 @@ static int rkisp1_probe(struct platform_device *pdev)
                                rkisp1->irqs[il] = irq;
                }
 
-               ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0,
+               ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED,
                                       dev_driver_string(dev), dev);
                if (ret) {
                        dev_err(dev, "request irq failed: %d\n", ret);