scsi: mpi3mr: Set MPI request flags appropriately
authorRanjan Kumar <ranjan.kumar@broadcom.com>
Wed, 13 Mar 2024 10:07:41 +0000 (15:37 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 25 Mar 2024 22:14:32 +0000 (18:14 -0400)
The 'flags' variable inside an MPI request is a bitfield and should
consequently be updated using a bitwise OR operation.

Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com>
Link: https://lore.kernel.org/r/20240313100746.128951-3-ranjan.kumar@broadcom.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr_os.c

index bfd32354b662f0d66ca187061300ee7d7121f9f1..5f975e0db38831328e48798c265318def3d0b6bc 100644 (file)
@@ -4895,7 +4895,7 @@ static int mpi3mr_qcmd(struct Scsi_Host *shost,
                    MPI3_SCSIIO_MSGFLAGS_DIVERT_TO_FIRMWARE;
                scsiio_flags |= MPI3_SCSIIO_FLAGS_DIVERT_REASON_IO_THROTTLING;
        }
-       scsiio_req->flags = cpu_to_le32(scsiio_flags);
+       scsiio_req->flags |= cpu_to_le32(scsiio_flags);
 
        if (mpi3mr_op_request_post(mrioc, op_req_q,
            scmd_priv_data->mpi3mr_scsiio_req)) {