projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fa55b7d
)
HSI: core: Fix return freed object in hsi_new_client
author
Chengfeng Ye
<cyeaa@connect.ust.hk>
Fri, 5 Nov 2021 13:45:07 +0000
(06:45 -0700)
committer
Sebastian Reichel
<sebastian.reichel@collabora.com>
Thu, 25 Nov 2021 23:27:06 +0000
(
00:27
+0100)
cl is freed on error of calling device_register, but this
object is return later, which will cause uaf issue. Fix it
by return NULL on error.
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/hsi/hsi_core.c
patch
|
blob
|
history
diff --git
a/drivers/hsi/hsi_core.c
b/drivers/hsi/hsi_core.c
index ec90713564e32d8091d0393f2df726acd1a49005..884066109699cf972a1723862b8ff61f71cf0943 100644
(file)
--- a/
drivers/hsi/hsi_core.c
+++ b/
drivers/hsi/hsi_core.c
@@
-102,6
+102,7
@@
struct hsi_client *hsi_new_client(struct hsi_port *port,
if (device_register(&cl->device) < 0) {
pr_err("hsi: failed to register client: %s\n", info->name);
put_device(&cl->device);
+ goto err;
}
return cl;